35 lines
1.3 KiB
Diff
35 lines
1.3 KiB
Diff
|
From e3d6d152a1cbdee25f2e3962009a2751b54e2297 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Kornel=20Dul=C4=99ba?= <mindal@semihalf.com>
|
||
|
|
Date: Thu, 26 Jan 2023 13:25:35 +0000
|
||
|
|
Subject: [PATCH] net: wwan: t7xx: Fix Runtime PM initialization
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
For PCI devices the Runtime PM refcount is incremented twice:
|
||
|
|
1. During device enumeration with a call to pm_runtime_forbid.
|
||
|
|
2. Just before a driver probe logic is called.
|
||
|
|
Because of that in order to enable Runtime PM on a given device
|
||
|
|
we have to call both pm_runtime_allow and pm_runtime_put_noidle,
|
||
|
|
once it's ready to be runtime suspended.
|
||
|
|
The former was missing causing the pm refcount to never reach 0.
|
||
|
|
|
||
|
|
Fixes: d10b3a695ba0 ("net: wwan: t7xx: Runtime PM")
|
||
|
|
Signed-off-by: Kornel Dulęba <mindal@semihalf.com>
|
||
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|
|
---
|
||
|
|
drivers/net/wwan/t7xx/t7xx_pci.c | 2 ++
|
||
|
|
1 file changed, 2 insertions(+)
|
||
|
|
|
||
|
|
--- a/drivers/net/wwan/t7xx/t7xx_pci.c
|
||
|
|
+++ b/drivers/net/wwan/t7xx/t7xx_pci.c
|
||
|
|
@@ -121,6 +121,8 @@ void t7xx_pci_pm_init_late(struct t7xx_p
|
||
|
|
iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + ENABLE_ASPM_LOWPWR);
|
||
|
|
atomic_set(&t7xx_dev->md_pm_state, MTK_PM_RESUMED);
|
||
|
|
|
||
|
|
+ pm_runtime_mark_last_busy(&t7xx_dev->pdev->dev);
|
||
|
|
+ pm_runtime_allow(&t7xx_dev->pdev->dev);
|
||
|
|
pm_runtime_put_noidle(&t7xx_dev->pdev->dev);
|
||
|
|
}
|
||
|
|
|