From 9495bbe075681931dfac7fd19ca5c841442e759b Mon Sep 17 00:00:00 2001 From: Paul Spooren Date: Thu, 28 Jan 2021 23:17:10 -1000 Subject: [PATCH] rules: fix empty COMMITCOUNT/AUTORELEASE Packages that are in-tree only often lack a PKG_VERSION and only use the PKG_RELEASE to mark changes. Using COMMITCOUNT/AUTORELEASE variables causes an issue as both variables are empty during the metadata DUMP phase. Instead of leaving these variables empty and causing an error message like below, set the variables to 0 during dumping. On actual building the variable is evaluated causing in a value above 0. ERROR: please fix package/utils/px5g-wolfssl/Makefile - \ see logs/package/utils/px5g-wolfssl/dump.txt for details Makefile:48: *** Package/px5g-wolfssl is missing the VERSION field. Stop. Reported-by: Daniel Golle Reported-by: Stijn Segers Reported-by: Stijn Tintel Signed-off-by: Paul Spooren --- rules.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules.mk b/rules.mk index ae4249d571..7d7851e32e 100644 --- a/rules.mk +++ b/rules.mk @@ -433,8 +433,8 @@ $(shell \ ) endef -COMMITCOUNT = $(if $(DUMP),,$(call commitcount)) -AUTORELEASE = $(if $(DUMP),,$(call commitcount,1)) +COMMITCOUNT = $(if $(DUMP),0,$(call commitcount)) +AUTORELEASE = $(if $(DUMP),0,$(call commitcount,1)) all: FORCE: ;