From 0bc3f51aa650ec9fea995233714219d2cb63f53c Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Fri, 28 May 2021 15:23:14 +0200 Subject: [PATCH 1/2] ubox: fix init script validation of log_ip option The underlying logread process uses usock() to handle remote connections which is able to handle both hostnames and IP addresses. Ref: https://github.com/openwrt/luci/issues/5077 Signed-off-by: Jo-Philipp Wich (cherry picked from commit ec83fb9ced138b7945135adffb9ff0ba63b695ec) --- package/system/ubox/Makefile | 2 +- package/system/ubox/files/log.init | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/system/ubox/Makefile b/package/system/ubox/Makefile index f32e93ca80..9ba4abdd58 100644 --- a/package/system/ubox/Makefile +++ b/package/system/ubox/Makefile @@ -1,7 +1,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=ubox -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE_PROTO:=git PKG_SOURCE_URL=$(PROJECT_GIT)/project/ubox.git diff --git a/package/system/ubox/files/log.init b/package/system/ubox/files/log.init index 250f805b44..c4802d4199 100644 --- a/package/system/ubox/files/log.init +++ b/package/system/ubox/files/log.init @@ -15,7 +15,7 @@ validate_log_section() 'log_file:string' \ 'log_size:uinteger' \ 'log_hostname:string' \ - 'log_ip:ipaddr' \ + 'log_ip:host' \ 'log_remote:bool:1' \ 'log_port:port:514' \ 'log_proto:or("tcp", "udp"):udp' \ From c2139eef279ef9efc30ddbaf08544f33eac63e36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Date: Fri, 28 May 2021 08:18:08 +0200 Subject: [PATCH 2/2] base-files: simplify setting device MAC MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. Move code above interface generation It results in more logical order. Device gets its config section above interface section. 2. Drop the loop We have separated code handling bridges now so $device should be guaranteed to contain a single device name. 3. Drop section name It's not required by netifd or LuCI & it's not needed by this script as $device contains a single device name now. Signed-off-by: Rafał Miłecki (cherry picked from commit e002179a6d2eea8640e262160030336bea54ec26) --- package/base-files/files/bin/config_generate | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/package/base-files/files/bin/config_generate b/package/base-files/files/bin/config_generate index d895090309..0dca5549e8 100755 --- a/package/base-files/files/bin/config_generate +++ b/package/base-files/files/bin/config_generate @@ -133,6 +133,14 @@ generate_network() { type="" } + if [ -n "$macaddr" ]; then + uci -q batch <<-EOF + add network device + set network.@device[-1].name='$device' + set network.@device[-1].macaddr='$macaddr' + EOF + fi + uci -q batch <<-EOF delete network.$1 set network.$1='interface' @@ -141,17 +149,6 @@ generate_network() { set network.$1.proto='none' EOF - if [ -n "$macaddr" ]; then - for name in $device; do - uci -q batch <<-EOF - delete network.$1_${name/./_}_dev - set network.$1_${name/./_}_dev='device' - set network.$1_${name/./_}_dev.name='$name' - set network.$1_${name/./_}_dev.macaddr='$macaddr' - EOF - done - fi - case "$protocol" in static) local ipad