43 lines
1.3 KiB
Diff
43 lines
1.3 KiB
Diff
From 1a9a71439cc1b270bf127c2f529aac7cf9cb21ab Mon Sep 17 00:00:00 2001
|
|
From: Boris Brezillon <boris.brezillon@collabora.com>
|
|
Date: Wed, 3 Jul 2024 09:16:39 +0200
|
|
Subject: [PATCH] drm/panthor: Don't check the array stride on empty uobj
|
|
arrays
|
|
|
|
The user is likely to leave all the drm_panthor_obj_array fields
|
|
to zero when the array is empty, which will cause an EINVAL failure.
|
|
|
|
v2:
|
|
- Added R-bs
|
|
|
|
Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
|
|
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
|
|
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
|
|
Reviewed-by: Steven Price <steven.price@arm.com>
|
|
Link: https://patchwork.freedesktop.org/patch/msgid/20240703071640.231278-2-boris.brezillon@collabora.com
|
|
---
|
|
drivers/gpu/drm/panthor/panthor_drv.c | 6 +++---
|
|
1 file changed, 3 insertions(+), 3 deletions(-)
|
|
|
|
--- a/drivers/gpu/drm/panthor/panthor_drv.c
|
|
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
|
|
@@ -86,15 +86,15 @@ panthor_get_uobj_array(const struct drm_
|
|
int ret = 0;
|
|
void *out_alloc;
|
|
|
|
+ if (!in->count)
|
|
+ return NULL;
|
|
+
|
|
/* User stride must be at least the minimum object size, otherwise it might
|
|
* lack useful information.
|
|
*/
|
|
if (in->stride < min_stride)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
- if (!in->count)
|
|
- return NULL;
|
|
-
|
|
out_alloc = kvmalloc_array(in->count, obj_size, GFP_KERNEL);
|
|
if (!out_alloc)
|
|
return ERR_PTR(-ENOMEM);
|