fbafc3e621/Documentation/networking/device_drivers/wwan/t7xx.rst
Signed-off-by: Tianling Shen <cnsztl@immortalwrt.org>
278 lines
9.1 KiB
Diff
278 lines
9.1 KiB
Diff
From d10b3a695ba0227faf249537402bb72b283a36b8 Mon Sep 17 00:00:00 2001
|
|
From: Haijun Liu <haijun.liu@mediatek.com>
|
|
Date: Fri, 6 May 2022 11:13:08 -0700
|
|
Subject: [PATCH] net: wwan: t7xx: Runtime PM
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Enables runtime power management callbacks including runtime_suspend
|
|
and runtime_resume. Autosuspend is used to prevent overhead by frequent
|
|
wake-ups.
|
|
|
|
Signed-off-by: Haijun Liu <haijun.liu@mediatek.com>
|
|
Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@intel.com>
|
|
Co-developed-by: Eliot Lee <eliot.lee@intel.com>
|
|
Signed-off-by: Eliot Lee <eliot.lee@intel.com>
|
|
Signed-off-by: Ricardo Martinez <ricardo.martinez@linux.intel.com>
|
|
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 14 ++++++++++++++
|
|
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 17 +++++++++++++++++
|
|
drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c | 15 +++++++++++++++
|
|
drivers/net/wwan/t7xx/t7xx_pci.c | 22 ++++++++++++++++++++++
|
|
4 files changed, 68 insertions(+)
|
|
|
|
--- a/drivers/net/wwan/t7xx/t7xx_hif_cldma.c
|
|
+++ b/drivers/net/wwan/t7xx/t7xx_hif_cldma.c
|
|
@@ -33,6 +33,7 @@
|
|
#include <linux/list.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/pci.h>
|
|
+#include <linux/pm_runtime.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/slab.h>
|
|
@@ -251,6 +252,8 @@ static void t7xx_cldma_rx_done(struct wo
|
|
t7xx_cldma_clear_ip_busy(&md_ctrl->hw_info);
|
|
t7xx_cldma_hw_irq_en_txrx(&md_ctrl->hw_info, queue->index, MTK_RX);
|
|
t7xx_cldma_hw_irq_en_eq(&md_ctrl->hw_info, queue->index, MTK_RX);
|
|
+ pm_runtime_mark_last_busy(md_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(md_ctrl->dev);
|
|
}
|
|
|
|
static int t7xx_cldma_gpd_tx_collect(struct cldma_queue *queue)
|
|
@@ -360,6 +363,9 @@ static void t7xx_cldma_tx_done(struct wo
|
|
t7xx_cldma_hw_irq_en_txrx(hw_info, queue->index, MTK_TX);
|
|
}
|
|
spin_unlock_irqrestore(&md_ctrl->cldma_lock, flags);
|
|
+
|
|
+ pm_runtime_mark_last_busy(md_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(md_ctrl->dev);
|
|
}
|
|
|
|
static void t7xx_cldma_ring_free(struct cldma_ctrl *md_ctrl,
|
|
@@ -568,6 +574,7 @@ static void t7xx_cldma_irq_work_cb(struc
|
|
if (l2_tx_int & (TXRX_STATUS_BITMASK | EMPTY_STATUS_BITMASK)) {
|
|
for_each_set_bit(i, &l2_tx_int, L2_INT_BIT_COUNT) {
|
|
if (i < CLDMA_TXQ_NUM) {
|
|
+ pm_runtime_get(md_ctrl->dev);
|
|
t7xx_cldma_hw_irq_dis_eq(hw_info, i, MTK_TX);
|
|
t7xx_cldma_hw_irq_dis_txrx(hw_info, i, MTK_TX);
|
|
queue_work(md_ctrl->txq[i].worker,
|
|
@@ -592,6 +599,7 @@ static void t7xx_cldma_irq_work_cb(struc
|
|
if (l2_rx_int & (TXRX_STATUS_BITMASK | EMPTY_STATUS_BITMASK)) {
|
|
l2_rx_int |= l2_rx_int >> CLDMA_RXQ_NUM;
|
|
for_each_set_bit(i, &l2_rx_int, CLDMA_RXQ_NUM) {
|
|
+ pm_runtime_get(md_ctrl->dev);
|
|
t7xx_cldma_hw_irq_dis_eq(hw_info, i, MTK_RX);
|
|
t7xx_cldma_hw_irq_dis_txrx(hw_info, i, MTK_RX);
|
|
queue_work(md_ctrl->rxq[i].worker, &md_ctrl->rxq[i].cldma_work);
|
|
@@ -922,6 +930,10 @@ int t7xx_cldma_send_skb(struct cldma_ctr
|
|
if (qno >= CLDMA_TXQ_NUM)
|
|
return -EINVAL;
|
|
|
|
+ ret = pm_runtime_resume_and_get(md_ctrl->dev);
|
|
+ if (ret < 0 && ret != -EACCES)
|
|
+ return ret;
|
|
+
|
|
queue = &md_ctrl->txq[qno];
|
|
|
|
spin_lock_irqsave(&md_ctrl->cldma_lock, flags);
|
|
@@ -965,6 +977,8 @@ int t7xx_cldma_send_skb(struct cldma_ctr
|
|
} while (!ret);
|
|
|
|
allow_sleep:
|
|
+ pm_runtime_mark_last_busy(md_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(md_ctrl->dev);
|
|
return ret;
|
|
}
|
|
|
|
--- a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c
|
|
+++ b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c
|
|
@@ -32,6 +32,7 @@
|
|
#include <linux/minmax.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/netdevice.h>
|
|
+#include <linux/pm_runtime.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/slab.h>
|
|
@@ -910,6 +911,7 @@ static void t7xx_dpmaif_rxq_work(struct
|
|
{
|
|
struct dpmaif_rx_queue *rxq = container_of(work, struct dpmaif_rx_queue, dpmaif_rxq_work);
|
|
struct dpmaif_ctrl *dpmaif_ctrl = rxq->dpmaif_ctrl;
|
|
+ int ret;
|
|
|
|
atomic_set(&rxq->rx_processing, 1);
|
|
/* Ensure rx_processing is changed to 1 before actually begin RX flow */
|
|
@@ -921,7 +923,14 @@ static void t7xx_dpmaif_rxq_work(struct
|
|
return;
|
|
}
|
|
|
|
+ ret = pm_runtime_resume_and_get(dpmaif_ctrl->dev);
|
|
+ if (ret < 0 && ret != -EACCES)
|
|
+ return;
|
|
+
|
|
t7xx_dpmaif_do_rx(dpmaif_ctrl, rxq);
|
|
+
|
|
+ pm_runtime_mark_last_busy(dpmaif_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(dpmaif_ctrl->dev);
|
|
atomic_set(&rxq->rx_processing, 0);
|
|
}
|
|
|
|
@@ -1123,11 +1132,19 @@ static void t7xx_dpmaif_bat_release_work
|
|
{
|
|
struct dpmaif_ctrl *dpmaif_ctrl = container_of(work, struct dpmaif_ctrl, bat_release_work);
|
|
struct dpmaif_rx_queue *rxq;
|
|
+ int ret;
|
|
+
|
|
+ ret = pm_runtime_resume_and_get(dpmaif_ctrl->dev);
|
|
+ if (ret < 0 && ret != -EACCES)
|
|
+ return;
|
|
|
|
/* ALL RXQ use one BAT table, so choose DPF_RX_QNO_DFT */
|
|
rxq = &dpmaif_ctrl->rxq[DPF_RX_QNO_DFT];
|
|
t7xx_dpmaif_bat_release_and_add(rxq);
|
|
t7xx_dpmaif_frag_bat_release_and_add(rxq);
|
|
+
|
|
+ pm_runtime_mark_last_busy(dpmaif_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(dpmaif_ctrl->dev);
|
|
}
|
|
|
|
int t7xx_dpmaif_bat_rel_wq_alloc(struct dpmaif_ctrl *dpmaif_ctrl)
|
|
--- a/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c
|
|
+++ b/drivers/net/wwan/t7xx/t7xx_hif_dpmaif_tx.c
|
|
@@ -28,6 +28,7 @@
|
|
#include <linux/list.h>
|
|
#include <linux/minmax.h>
|
|
#include <linux/netdevice.h>
|
|
+#include <linux/pm_runtime.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/skbuff.h>
|
|
@@ -161,6 +162,10 @@ static void t7xx_dpmaif_tx_done(struct w
|
|
struct dpmaif_hw_info *hw_info;
|
|
int ret;
|
|
|
|
+ ret = pm_runtime_resume_and_get(dpmaif_ctrl->dev);
|
|
+ if (ret < 0 && ret != -EACCES)
|
|
+ return;
|
|
+
|
|
hw_info = &dpmaif_ctrl->hw_info;
|
|
ret = t7xx_dpmaif_tx_release(dpmaif_ctrl, txq->index, txq->drb_size_cnt);
|
|
if (ret == -EAGAIN ||
|
|
@@ -174,6 +179,9 @@ static void t7xx_dpmaif_tx_done(struct w
|
|
t7xx_dpmaif_clr_ip_busy_sts(hw_info);
|
|
t7xx_dpmaif_unmask_ulq_intr(hw_info, txq->index);
|
|
}
|
|
+
|
|
+ pm_runtime_mark_last_busy(dpmaif_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(dpmaif_ctrl->dev);
|
|
}
|
|
|
|
static void t7xx_setup_msg_drb(struct dpmaif_ctrl *dpmaif_ctrl, unsigned int q_num,
|
|
@@ -423,6 +431,7 @@ static void t7xx_do_tx_hw_push(struct dp
|
|
static int t7xx_dpmaif_tx_hw_push_thread(void *arg)
|
|
{
|
|
struct dpmaif_ctrl *dpmaif_ctrl = arg;
|
|
+ int ret;
|
|
|
|
while (!kthread_should_stop()) {
|
|
if (t7xx_tx_lists_are_all_empty(dpmaif_ctrl) ||
|
|
@@ -437,7 +446,13 @@ static int t7xx_dpmaif_tx_hw_push_thread
|
|
break;
|
|
}
|
|
|
|
+ ret = pm_runtime_resume_and_get(dpmaif_ctrl->dev);
|
|
+ if (ret < 0 && ret != -EACCES)
|
|
+ return ret;
|
|
+
|
|
t7xx_do_tx_hw_push(dpmaif_ctrl);
|
|
+ pm_runtime_mark_last_busy(dpmaif_ctrl->dev);
|
|
+ pm_runtime_put_autosuspend(dpmaif_ctrl->dev);
|
|
}
|
|
|
|
return 0;
|
|
--- a/drivers/net/wwan/t7xx/t7xx_pci.c
|
|
+++ b/drivers/net/wwan/t7xx/t7xx_pci.c
|
|
@@ -31,6 +31,7 @@
|
|
#include <linux/mutex.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/pm.h>
|
|
+#include <linux/pm_runtime.h>
|
|
#include <linux/pm_wakeup.h>
|
|
|
|
#include "t7xx_mhccif.h"
|
|
@@ -44,6 +45,7 @@
|
|
#define T7XX_PCI_EREG_BASE 2
|
|
|
|
#define PM_ACK_TIMEOUT_MS 1500
|
|
+#define PM_AUTOSUSPEND_MS 20000
|
|
#define PM_RESOURCE_POLL_TIMEOUT_US 10000
|
|
#define PM_RESOURCE_POLL_STEP_US 100
|
|
|
|
@@ -82,6 +84,8 @@ static int t7xx_pci_pm_init(struct t7xx_
|
|
DPM_FLAG_NO_DIRECT_COMPLETE);
|
|
|
|
iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + DISABLE_ASPM_LOWPWR);
|
|
+ pm_runtime_set_autosuspend_delay(&pdev->dev, PM_AUTOSUSPEND_MS);
|
|
+ pm_runtime_use_autosuspend(&pdev->dev);
|
|
|
|
return t7xx_wait_pm_config(t7xx_dev);
|
|
}
|
|
@@ -96,6 +100,8 @@ void t7xx_pci_pm_init_late(struct t7xx_p
|
|
D2H_INT_RESUME_ACK_AP);
|
|
iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + ENABLE_ASPM_LOWPWR);
|
|
atomic_set(&t7xx_dev->md_pm_state, MTK_PM_RESUMED);
|
|
+
|
|
+ pm_runtime_put_noidle(&t7xx_dev->pdev->dev);
|
|
}
|
|
|
|
static int t7xx_pci_pm_reinit(struct t7xx_pci_dev *t7xx_dev)
|
|
@@ -104,6 +110,9 @@ static int t7xx_pci_pm_reinit(struct t7x
|
|
* so just roll back PM setting to the init setting.
|
|
*/
|
|
atomic_set(&t7xx_dev->md_pm_state, MTK_PM_INIT);
|
|
+
|
|
+ pm_runtime_get_noresume(&t7xx_dev->pdev->dev);
|
|
+
|
|
iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + DISABLE_ASPM_LOWPWR);
|
|
return t7xx_wait_pm_config(t7xx_dev);
|
|
}
|
|
@@ -403,6 +412,7 @@ static int __t7xx_pci_pm_resume(struct p
|
|
t7xx_dev->rgu_pci_irq_en = true;
|
|
t7xx_pcie_mac_set_int(t7xx_dev, SAP_RGU_INT);
|
|
iowrite32(T7XX_L1_BIT(0), IREG_BASE(t7xx_dev) + ENABLE_ASPM_LOWPWR);
|
|
+ pm_runtime_mark_last_busy(&pdev->dev);
|
|
atomic_set(&t7xx_dev->md_pm_state, MTK_PM_RESUMED);
|
|
|
|
return ret;
|
|
@@ -439,6 +449,16 @@ static int t7xx_pci_pm_thaw(struct devic
|
|
return __t7xx_pci_pm_resume(to_pci_dev(dev), false);
|
|
}
|
|
|
|
+static int t7xx_pci_pm_runtime_suspend(struct device *dev)
|
|
+{
|
|
+ return __t7xx_pci_pm_suspend(to_pci_dev(dev));
|
|
+}
|
|
+
|
|
+static int t7xx_pci_pm_runtime_resume(struct device *dev)
|
|
+{
|
|
+ return __t7xx_pci_pm_resume(to_pci_dev(dev), true);
|
|
+}
|
|
+
|
|
static const struct dev_pm_ops t7xx_pci_pm_ops = {
|
|
.suspend = t7xx_pci_pm_suspend,
|
|
.resume = t7xx_pci_pm_resume,
|
|
@@ -448,6 +468,8 @@ static const struct dev_pm_ops t7xx_pci_
|
|
.poweroff = t7xx_pci_pm_suspend,
|
|
.restore = t7xx_pci_pm_resume,
|
|
.restore_noirq = t7xx_pci_pm_resume_noirq,
|
|
+ .runtime_suspend = t7xx_pci_pm_runtime_suspend,
|
|
+ .runtime_resume = t7xx_pci_pm_runtime_resume
|
|
};
|
|
|
|
static int t7xx_request_irq(struct pci_dev *pdev)
|